From 6d13ee7d3aa4157d647cded90f959051f1746543 Mon Sep 17 00:00:00 2001 From: DavidBadura Date: Sun, 8 Feb 2015 13:29:44 +0000 Subject: [PATCH] update recurring --- README.md | 4 ++-- src/Recurring.php | 4 ++-- src/Task.php | 4 ++-- src/TaskManager.php | 8 ++++---- tests/TaskManagerTest.php | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/README.md b/README.md index 0869082..eea2d34 100644 --- a/README.md +++ b/README.md @@ -14,10 +14,10 @@ $tm = TaskManager::create(); $task = new Task(); $task->setDescription('program this lib'); $task->setProject('hobby'); -$task->setDue(new \DateTime('tomorrow')); +$task->setDue('tomorrow'); $task->setPriority(Task::PRIORITY_HIGH); $task->addTag('next'); -$task->setRecur(new Recurring(Recurring::DAILY)); +$task->setRecurring(Recurring::DAILY); $tm->save($task); diff --git a/src/Recurring.php b/src/Recurring.php index 0c9281d..e0ffb23 100644 --- a/src/Recurring.php +++ b/src/Recurring.php @@ -32,7 +32,7 @@ class Recurring */ public function __construct($recurring) { - if ($this->isValid($recurring)) { + if (self::isValid($recurring)) { $this->recurring = $recurring; } else { throw new TaskwarriorException(); @@ -51,7 +51,7 @@ class Recurring * @param string $recur * @return bool */ - private function isValid($recur) + public static function isValid($recur) { $refClass = new \ReflectionClass(__CLASS__); $constants = $refClass->getConstants(); diff --git a/src/Task.php b/src/Task.php index 13a1fa6..2a577ca 100644 --- a/src/Task.php +++ b/src/Task.php @@ -263,7 +263,7 @@ class Task /** * @return string */ - public function getRecur() + public function getRecurring() { return $this->recur; } @@ -272,7 +272,7 @@ class Task * @param string|Recurring $recur * @throws TaskwarriorException */ - public function setRecur($recur) + public function setRecurring($recur) { if (is_string($recur)) { $this->recur = new Recurring($recur); diff --git a/src/TaskManager.php b/src/TaskManager.php index 6c20d9f..61940e9 100644 --- a/src/TaskManager.php +++ b/src/TaskManager.php @@ -264,10 +264,10 @@ class TaskManager */ private function setValue(Task $task, $attr, $value) { - $reflectionClass = new \ReflectionClass('DavidBadura\Taskwarrior\Task'); - $prop = $reflectionClass->getProperty($attr); - $prop->setAccessible(true); - $prop->setValue($task, $value); + $refClass = new \ReflectionClass('DavidBadura\Taskwarrior\Task'); + $refProp = $refClass->getProperty($attr); + $refProp->setAccessible(true); + $refProp->setValue($task, $value); } /** diff --git a/tests/TaskManagerTest.php b/tests/TaskManagerTest.php index 68856a7..5418de9 100644 --- a/tests/TaskManagerTest.php +++ b/tests/TaskManagerTest.php @@ -512,7 +512,7 @@ class TaskManagerTest extends \PHPUnit_Framework_TestCase $task1 = new Task(); $task1->setDescription('foo1'); $task1->setDue('tomorrow'); - $task1->setRecur('daily'); + $task1->setRecurring('daily'); $this->taskManager->save($task1);